mirror/superpowers
1
0
Fork 0
mirror of https://github.com/obra/superpowers.git synced 2026-09-02 11:45:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
400 Commits 112 Branches 34 Tags
f146752b8d42ff2fe14c23ce62daf22b95873a4e
Commit Graph
16 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Drew RitterandClaude Opus 4.6 f146752b8d fix(finishing-skill): move environment detection before test verification (PRI-823) 
Path A (detached HEAD in externally managed worktree) was unreachable
because Step 1 halted on test failure before Step 1.5 could detect the
restricted environment. Reorder so detection runs first — Path A now
skips test verification entirely since the toolchain may not be available
in sandbox environments.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 18:47:40 -07:00
Drew RitterandClaude Opus 4.6 2cbbd8ce88 fix(test): use single-quoted trap for safer cleanup (PRI-823) 
Defers $TEMP_DIR expansion to execution time and quotes the variable
inside the trap, protecting against paths with spaces.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 18:47:40 -07:00
Drew RitterandClaude Opus 4.6 97677b2b24 test: add environment detection tests for Codex App compat (PRI-823) 
Tests git-dir vs git-common-dir comparison in normal repo, linked
worktree, detached HEAD, and cleanup guard scenarios.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 18:47:40 -07:00
Drew RitterandClaude Opus 4.6 46078a1a90 docs(codex-tools): add environment detection and App finishing docs (PRI-823) 
Document the git-dir vs git-common-dir detection pattern and the Codex
App's native finishing flow for skills that need to adapt.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 18:47:40 -07:00
Drew RitterandClaude Opus 4.6 4351ee23dc docs(sdd, executing-plans): update worktree Integration descriptions (PRI-823) 
Clarify that using-git-worktrees ensures a workspace exists rather than
always creating one.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 18:47:40 -07:00
Drew RitterandClaude Opus 4.6 c319e2be6d feat(finishing-a-development-branch): add Step 5 cleanup guard (PRI-823) 
Re-detect externally managed worktree at cleanup time and skip removal.
Also fixes pre-existing inconsistency: cleanup now correctly says
Options 1 and 4 only, matching Quick Reference and Common Mistakes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 18:47:40 -07:00
Drew RitterandClaude Opus 4.6 9c63edc732 feat(finishing-a-development-branch): add Step 1.5 environment detection (PRI-823) 
Detect externally managed worktrees with detached HEAD and emit handoff
payload instead of 4-option menu. Includes commit SHA and data loss warning.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 18:47:40 -07:00
Drew Ritter a26ab96bad docs(using-git-worktrees): update Integration descriptions (PRI-823) 
Clarify that skill ensures a workspace exists, not that it always creates one.
 2026-03-23 18:47:40 -07:00
Drew Ritter 747355018b feat(using-git-worktrees): add Step 0 environment detection (PRI-823) 
Skip worktree creation when already in a linked worktree. Includes
sandbox fallback for permission errors on git worktree add.
 2026-03-23 18:47:40 -07:00
Drew Ritter 7820adcde7 docs(codex-tools): add named agent dispatch mapping for Codex (#647) 2026-03-23 17:37:54 -07:00
Drew RitterandClaude Opus 4.6 250dea46fd docs: add implementation plan for Codex App compatibility (PRI-823) 
8 tasks covering: environment detection in using-git-worktrees,
Step 1.5 + cleanup guard in finishing-a-development-branch,
Integration line updates, codex-tools.md docs, automated tests,
and final verification.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 17:37:54 -07:00
Drew RitterandClaude Opus 4.6 477c55386a docs: add cleanup guard test (#5) and sandbox fallback test (#10) to spec 
Both tests address real risk scenarios:
- #5: cleanup guard bug would delete Codex App's own worktree (data loss)
- #10: Local thread sandbox fallback needs manual Codex App validation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 17:37:54 -07:00
Drew RitterandClaude Opus 4.6 cb4745eeb5 docs: clarify executing-plans in What Does NOT Change section 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 17:37:54 -07:00
Drew RitterandClaude Opus 4.6 872ec69f4c docs: address team review feedback for PRI-823 spec 
- Add commit SHA + data loss warning to handoff payload (HIGH)
- Add explicit commit step before handoff (HIGH)
- Remove misleading "mark as externally managed" from Path B
- Add executing-plans 1-line edit (was missing)
- Add branch name derivation rules
- Add conditional UI language for non-App environments
- Add sandbox fallback for permission errors
- Add STOP directive after Step 0 reporting

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 17:37:54 -07:00
Drew RitterandClaude Opus 4.6 e0fcfaf838 docs: address spec review feedback for PRI-823 
Fix three Important issues from spec review:
- Clarify Step 1.5 placement relative to existing Steps 2/3
- Re-derive environment state at cleanup time instead of relying on
  earlier skill output
- Acknowledge pre-existing Step 5 cleanup inconsistency

Also: precise step references, exact codex-tools.md content, clearer
Integration section update instructions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 17:37:54 -07:00
Drew RitterandClaude Opus 4.6 5bf3f77483 docs: add Codex App compatibility design spec (PRI-823) 
Design for making using-git-worktrees, finishing-a-development-branch,
and subagent-driven-development skills work in the Codex App's sandboxed
worktree environment. Read-only environment detection via git-dir vs
git-common-dir comparison, ~48 lines across 4 files, zero breaking changes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-03-23 17:37:54 -07:00