Make the entire card clickable on Installed Charts view (#87)

Co-authored-by: Harshit Mehta <harshitm@nvidia.com>
This commit is contained in:
Harshit Mehta
2022-11-24 14:45:33 +05:30
committed by GitHub
parent 5cccb1caa0
commit 8334f2b0b2
2 changed files with 11 additions and 4 deletions

View File

@@ -22,8 +22,8 @@ function loadChartsList() {
function buildChartCard(elm) { function buildChartCard(elm) {
const card = $(`<div class="row m-0 py-4 bg-white rounded-1 b-shadow border-4 border-start"> const card = $(`<div class="row m-0 py-4 bg-white rounded-1 b-shadow border-4 border-start link">
<div class="col-4 rel-name"><span class="link">release-name</span><div></div></div> <div class="col-4 rel-name"><span>release-name</span><div></div></div>
<div class="col-3 rel-status"><span></span><div></div></div> <div class="col-3 rel-status"><span></span><div></div></div>
<div class="col-2 rel-chart text-nowrap"><span></span><div>Chart Version</div></div> <div class="col-2 rel-chart text-nowrap"><span></span><div>Chart Version</div></div>
<div class="col-1 rel-rev"><span>#0</span><div>Revision</div></div> <div class="col-1 rel-rev"><span>#0</span><div>Revision</div></div>
@@ -69,7 +69,10 @@ function buildChartCard(elm) {
card.find("a").attr("href", '#context=' + getHashParam('context') + '&namespace=' + elm.namespace + '&name=' + elm.name) card.find("a").attr("href", '#context=' + getHashParam('context') + '&namespace=' + elm.namespace + '&name=' + elm.name)
card.find(".rel-name span").data("chart", elm).click(function () { card.data("chart", elm).click(function () {
if (window.getSelection().toString()) {
return
}
const self = $(this) const self = $(this)
$("#sectionList").hide() $("#sectionList").hide()

View File

@@ -32,7 +32,7 @@ function fillChartHistory(data, namespace, name) {
$("#specRev").val(elm.revision).data("last-rev", elm.revision).data("last-chart-ver", elm.chart_ver) $("#specRev").val(elm.revision).data("last-rev", elm.revision).data("last-chart-ver", elm.chart_ver)
} }
const rev = $(`<li class="px-2 pt-5 pb-4 mb-2 rounded border border-secondary bg-secondary position-relative"> const rev = $(`<li class="px-2 pt-5 pb-4 mb-2 rounded border border-secondary bg-secondary position-relative link">
<div class="rev-status position-absolute top-0 m-2 mb-5 start-0 fw-bold"></div> <div class="rev-status position-absolute top-0 m-2 mb-5 start-0 fw-bold"></div>
<div class="rev-number position-absolute top-0 m-2 mb-5 end-0 fw-bold fs-6"></div> <div class="rev-number position-absolute top-0 m-2 mb-5 end-0 fw-bold fs-6"></div>
<div class="rev-changes position-absolute bottom-0 start-0 m-2 text-muted small"></div> <div class="rev-changes position-absolute bottom-0 start-0 m-2 text-muted small"></div>
@@ -61,9 +61,13 @@ function fillChartHistory(data, namespace, name) {
rev.data("elm", elm) rev.data("elm", elm)
rev.addClass("rev-" + elm.revision) rev.addClass("rev-" + elm.revision)
rev.click(function () { rev.click(function () {
if (window.getSelection().toString()) {
return
}
revisionClicked(namespace, name, $(this)) revisionClicked(namespace, name, $(this))
}) })
// revRow.attr("class", "link")
revRow.append(rev) revRow.append(rev)
} }
} }