From 8334f2b0b28f7f3fe00667ed49edf4d3bddb3f7b Mon Sep 17 00:00:00 2001
From: Harshit Mehta <hdm23061993@gmail.com>
Date: Thu, 24 Nov 2022 14:45:33 +0530
Subject: [PATCH] Make the entire card clickable on Installed Charts view (#87)

Co-authored-by: Harshit Mehta <harshitm@nvidia.com>
---
 pkg/dashboard/static/list-view.js      | 9 ++++++---
 pkg/dashboard/static/revisions-view.js | 6 +++++-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/pkg/dashboard/static/list-view.js b/pkg/dashboard/static/list-view.js
index dce1889..3b4d836 100644
--- a/pkg/dashboard/static/list-view.js
+++ b/pkg/dashboard/static/list-view.js
@@ -22,8 +22,8 @@ function loadChartsList() {
 
 
 function buildChartCard(elm) {
-    const card = $(`<div class="row m-0 py-4 bg-white rounded-1 b-shadow border-4 border-start">
-            <div class="col-4 rel-name"><span class="link">release-name</span><div></div></div>
+    const card = $(`<div class="row m-0 py-4 bg-white rounded-1 b-shadow border-4 border-start link">
+            <div class="col-4 rel-name"><span>release-name</span><div></div></div>
             <div class="col-3 rel-status"><span></span><div></div></div>
             <div class="col-2 rel-chart text-nowrap"><span></span><div>Chart Version</div></div>
             <div class="col-1 rel-rev"><span>#0</span><div>Revision</div></div>
@@ -69,7 +69,10 @@ function buildChartCard(elm) {
 
     card.find("a").attr("href", '#context=' + getHashParam('context') + '&namespace=' + elm.namespace + '&name=' + elm.name)
 
-    card.find(".rel-name span").data("chart", elm).click(function () {
+    card.data("chart", elm).click(function () {
+        if (window.getSelection().toString()) {
+            return
+        }
         const self = $(this)
         $("#sectionList").hide()
 
diff --git a/pkg/dashboard/static/revisions-view.js b/pkg/dashboard/static/revisions-view.js
index 9f939ca..550aa98 100644
--- a/pkg/dashboard/static/revisions-view.js
+++ b/pkg/dashboard/static/revisions-view.js
@@ -32,7 +32,7 @@ function fillChartHistory(data, namespace, name) {
             $("#specRev").val(elm.revision).data("last-rev", elm.revision).data("last-chart-ver", elm.chart_ver)
         }
 
-        const rev = $(`<li class="px-2 pt-5 pb-4 mb-2 rounded border border-secondary bg-secondary position-relative">
+        const rev = $(`<li class="px-2 pt-5 pb-4 mb-2 rounded border border-secondary bg-secondary position-relative link">
                                 <div class="rev-status position-absolute top-0 m-2 mb-5 start-0 fw-bold"></div>
                                 <div class="rev-number position-absolute top-0 m-2 mb-5 end-0 fw-bold fs-6"></div>
                                 <div class="rev-changes position-absolute bottom-0 start-0 m-2 text-muted small"></div>
@@ -61,9 +61,13 @@ function fillChartHistory(data, namespace, name) {
         rev.data("elm", elm)
         rev.addClass("rev-" + elm.revision)
         rev.click(function () {
+            if (window.getSelection().toString()) {
+                return
+            }
             revisionClicked(namespace, name, $(this))
         })
 
+        // revRow.attr("class", "link")
         revRow.append(rev)
     }
 }