mirror/superpowers
1
0
Fork 0
mirror of https://github.com/obra/superpowers.git synced 2026-08-07 15:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(e2e): confine scenario card validation

Browse Source 
Reuse the bounded fence filter for every scenario-card structural check so headings, coverage text, and falsification prose inside examples cannot satisfy the gate. Valid cards may still contain unrelated fenced examples.\n\nTreat each Card cell as a filename stem: remove at most one enclosing backtick pair, require lowercase kebab case, and reject invalid values before they can be stored or joined to the cards directory. This blocks parent traversal, subdirectories, uppercase names, and empty segments.\n\nAdd real-process RED/GREEN coverage for fenced-only cards, traversal, invalid stems, preserved backtick behavior, and the explicit diagnostic for intentionally unsupported pipe-less tables.
This commit is contained in:
Drew Ritter
2026-08-06 14:50:46 -07:00
parent 2a2e0b41c2
commit 7dff0b2d48
2 changed files with 89 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/agentic-e2e-checker/test-check-cards-against-spec.sh
+73
View File
@@ -254,6 +254,79 @@ EOF
assert_exit 0 "real table after fenced example -> exit 0" \
"$CHECKER" "$TEST_ROOT/t13/spec.md" "$TEST_ROOT/t13/cards"
echo "card structure inside a fenced example does not count"
make_spec "$TEST_ROOT/t14"; make_cards "$TEST_ROOT/t14/cards"
cat > "$TEST_ROOT/t14/cards/widget-show-table.md" <<'EOF'
# widget-show-table: illustrative card only
~~~markdown
**What this covers**: the rendered table.
## Pre-state
A built widget binary.
## Steps
1. Run `widget show`.
## Expected
If stdout's last line is not `TOTAL` followed by the two-decimal sum (20.85 for the seed fixture), or the TOTAL row is absent entirely, the scenario FAILS.
## Cleanup
Nothing to clean.
~~~
EOF
assert_exit 1 "required card content found only inside a fence -> exit 1" \
"$CHECKER" "$TEST_ROOT/t14/spec.md" "$TEST_ROOT/t14/cards"
echo "unrelated fenced examples remain valid card content"
make_spec "$TEST_ROOT/t15"; make_cards "$TEST_ROOT/t15/cards"
cat >> "$TEST_ROOT/t15/cards/widget-show-table.md" <<'EOF'
```console
$ widget show
TOTAL 20.85
```
EOF
assert_exit 0 "valid card with unrelated fenced example -> exit 0" \
"$CHECKER" "$TEST_ROOT/t15/spec.md" "$TEST_ROOT/t15/cards"
echo "card names cannot traverse outside the cards directory"
make_spec "$TEST_ROOT/t16"; make_cards "$TEST_ROOT/t16/cards"
sed -i.bak 's/| widget-show-table |/| ..\/outside |/' "$TEST_ROOT/t16/spec.md"
mv "$TEST_ROOT/t16/cards/widget-show-table.md" "$TEST_ROOT/t16/outside.md"
assert_exit 1 "parent-traversing Card value -> exit 1" \
"$CHECKER" "$TEST_ROOT/t16/spec.md" "$TEST_ROOT/t16/cards"
assert_out_contains "invalid Card value" "traversal failure names the invalid value"
echo "card names use lowercase kebab case"
make_spec "$TEST_ROOT/t17"; make_cards "$TEST_ROOT/t17/cards"
sed -i.bak 's/| widget-show-table |/| Upper-Case |/' "$TEST_ROOT/t17/spec.md"
mv "$TEST_ROOT/t17/cards/widget-show-table.md" "$TEST_ROOT/t17/cards/Upper-Case.md"
assert_exit 1 "uppercase Card value -> exit 1" \
"$CHECKER" "$TEST_ROOT/t17/spec.md" "$TEST_ROOT/t17/cards"
assert_out_contains "invalid Card value" "uppercase failure names the invalid value"
make_spec "$TEST_ROOT/t18"; make_cards "$TEST_ROOT/t18/cards"
sed -i.bak 's/| widget-show-table |/| two--segments |/' "$TEST_ROOT/t18/spec.md"
mv "$TEST_ROOT/t18/cards/widget-show-table.md" "$TEST_ROOT/t18/cards/two--segments.md"
assert_exit 1 "empty kebab segment -> exit 1" \
"$CHECKER" "$TEST_ROOT/t18/spec.md" "$TEST_ROOT/t18/cards"
assert_out_contains "invalid Card value" "empty-segment failure names the invalid value"
echo "one enclosing backtick pair remains supported"
make_spec "$TEST_ROOT/t19"; make_cards "$TEST_ROOT/t19/cards"
sed -i.bak 's/| widget-show-table |/| `widget-show-table` |/' "$TEST_ROOT/t19/spec.md"
assert_exit 0 "backticked kebab-case Card value -> exit 0" \
"$CHECKER" "$TEST_ROOT/t19/spec.md" "$TEST_ROOT/t19/cards"
echo "pipe-less tables report the canonical outer-pipe contract"
make_spec "$TEST_ROOT/t20"; make_cards "$TEST_ROOT/t20/cards"
sed -E -i.bak 's/^\| (.*) \|$/\1/' "$TEST_ROOT/t20/spec.md"
assert_exit 2 "pipe-less table remains unsupported -> exit 2" \
"$CHECKER" "$TEST_ROOT/t20/spec.md" "$TEST_ROOT/t20/cards"
assert_out_contains "scenario table rows must use leading and trailing outer pipes" \
"diagnostic names the canonical outer-pipe contract"
echo "no scenario table"
mkdir -p "$TEST_ROOT/t7/cards"
printf '# Widget Design\n\nNo table here.\n' > "$TEST_ROOT/t7/spec.md"