From b0067e31ba9a5d38ebe41399319e2d07b0e2bbb0 Mon Sep 17 00:00:00 2001
From: Andrey Pokhilko <andrei.pokhilko@gmail.com>
Date: Wed, 26 Oct 2022 11:05:50 +0100
Subject: [PATCH] Improvements after release (#45)

* Add helm version requirement notes

* Create Help section, no charts placeholder

* Revive missed "user-defined" values

* Fix namespace undefined upon install

* cosmetics
---
 README.md                         |  4 +++-
 pkg/dashboard/static/actions.js   |  3 ++-
 pkg/dashboard/static/index.html   | 33 +++++++++++++++++++++++--------
 pkg/dashboard/static/list-view.js |  4 ++++
 pkg/dashboard/static/styles.css   |  4 ++++
 5 files changed, 38 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index bbfc403..bc442f1 100644
--- a/README.md
+++ b/README.md
@@ -42,9 +42,11 @@ To uninstall, run:
 helm plugin uninstall dashboard
 ```
 
+Note: In case standard Helm plugin way did not work for you, you can just download the appropriate [release package](https://github.com/komodorio/helm-dashboard/releases) for your platform, unpack it and just run `dashboard` binary from it.
+
 ## Running
 
-To use the plugin, your machine needs to have working `helm` and also `kubectl` commands.
+To use the plugin, your machine needs to have working `helm` and also `kubectl` commands. Helm version 3.4.0+ is required.
 
 After installing, start the UI by running:
 
diff --git a/pkg/dashboard/static/actions.js b/pkg/dashboard/static/actions.js
index 8f79465..e58a7ae 100644
--- a/pkg/dashboard/static/actions.js
+++ b/pkg/dashboard/static/actions.js
@@ -112,7 +112,8 @@ $("#upgradeModal .btn-confirm").click(function () {
     }).done(function (data) {
         if (data.version) {
             setHashParam("section", null)
-            setHashParam("namespace", $("#upgradeModal .rel-ns").val())
+            const ns = $("#upgradeModal .rel-ns").val();
+            setHashParam("namespace", ns ? ns : "default")
             setHashParam("chart", $("#upgradeModal .rel-name").val())
             setHashParam("revision", data.version)
             window.location.reload()
diff --git a/pkg/dashboard/static/index.html b/pkg/dashboard/static/index.html
index 132b0f9..a1e0607 100644
--- a/pkg/dashboard/static/index.html
+++ b/pkg/dashboard/static/index.html
@@ -44,9 +44,6 @@
                 </div>
             </div>
 
-            <div id="toolVersion">
-            </div>
-            
             <div class="separator-vertical mx-3"><span></span></div>
 
             <ul class="navbar-nav me-auto mb-2 mb-lg-0">
@@ -56,14 +53,28 @@
                 <li class="nav-item mx-2">
                     <a class="nav-link px-3 section-repo">Repository</a>
                 </li>
+                <li class="nav-item dropdown">
+                    <a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown"
+                       aria-expanded="false">
+                        Help
+                    </a>
+                    <ul class="dropdown-menu fs-80">
+                        <li><a class="dropdown-item" href="https://komodorkommunity.slack.com/archives/C044U1B0265"
+                               target="_blank"><i class="bi-slack"></i> Support Chat</a></li>
+                        <li><a class="dropdown-item" href="https://github.com/komodorio/helm-dashboard" target="_blank"><i
+                                class="bi-github"></i> Project Page</a></li>
+                        <li>
+                            <hr class="dropdown-divider">
+                        </li>
+                        <li><a class="dropdown-item disabled" href="#">Version <span id="toolVersion"></span></a></li>
+                    </ul>
+                </li>
+
             </ul>
             <div>
                 <a class="btn" href="https://komodor.com/?utm_campaign=Helm-Dash&utm_source=helm-dash"><img
-                        src="https://komodor.com/wp-content/uploads/2021/05/favicon.png" alt="komodor.io"
+                        src="static/komodor-logo.svg" alt="komodor.io"
                         style="height: 1.2rem; vertical-align: text-bottom; filter: grayscale(00%);"></a>
-
-                <a class="btn me-2 text-muted" href="https://github.com/komodorio/helm-dashboard"
-                   title="Project page on GitHub"><i class="bi-github"></i></a>
             </div>
             <div class="separator-vertical"><span></span></div>
             <i class="btn bi-power text-muted p-2 m-1 mx-2" title="Shut down the Helm Dashboard application"></i>
@@ -99,7 +110,7 @@
             </div>
 
             <div class="float-end">
-            <!-- TODO   <input class="form-control form-control-sm" type="text" placeholder="Filter..."> -->
+                <!-- TODO   <input class="form-control form-control-sm" type="text" placeholder="Filter..."> -->
             </div>
             <div class="row bg-secondary rounded px-3 py-2 mb-3 fw-bold small"
                  style="text-transform: uppercase">
@@ -150,6 +161,9 @@
             </div>
 
             <div class="body"></div>
+            <div class="bg-white rounded shadow p-3 display-none no-charts">Looks like you don't have any charts
+                installed. "Repository" section may be a good place to start.
+            </div>
         </div>
         <!-- /INSTALLED LIST -->
     </div>
@@ -254,6 +268,9 @@
                                        data-mode="diff-rev">
                                 Diff with specific revision: <input class="form-input" size="3" id="specRev">
                             </label>
+                            <label class="form-check-label" for="userDefinedVals">
+                                <input class="form-check-input" type="checkbox" id="userDefinedVals"> User-defined only
+                            </label>
                         </form>
                     </nav>
 
diff --git a/pkg/dashboard/static/list-view.js b/pkg/dashboard/static/list-view.js
index 212a806..e3d804f 100644
--- a/pkg/dashboard/static/list-view.js
+++ b/pkg/dashboard/static/list-view.js
@@ -12,6 +12,10 @@ function loadChartsList() {
             let card = buildChartCard(elm);
             chartsCards.append(card)
         })
+
+        if (!data.length) {
+            $("#installedList .no-charts").show()
+        }
     })
 }
 
diff --git a/pkg/dashboard/static/styles.css b/pkg/dashboard/static/styles.css
index 40a8db5..914417c 100644
--- a/pkg/dashboard/static/styles.css
+++ b/pkg/dashboard/static/styles.css
@@ -76,6 +76,10 @@
     min-width: 60%;
 }
 
+.fs-80 {
+    font-size: 0.8rem!important;
+}
+
 html {
     min-height: 100%;
 }