From 81e982941de2f63698db58ffac5561c258089739 Mon Sep 17 00:00:00 2001
From: Andrey Pokhilko <andrei@komodor.io>
Date: Fri, 27 Mar 2026 14:01:00 +0300
Subject: [PATCH] fix: manifest diff shows all resources as recreated (#672)
 (#673)

The manifests endpoint returns text/plain YAML, but fetchWithSafeDefaults
treats string responses as errors and returns the fallback value ([]).
Revert useGetReleaseManifest to use fetchWithDefaults which correctly
passes through text/plain responses.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 frontend/src/API/releases.ts                          | 11 +++++------
 .../InstallChartModal/InstallReleaseChartModal.tsx    |  2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/frontend/src/API/releases.ts b/frontend/src/API/releases.ts
index 4e421d0..4005355 100644
--- a/frontend/src/API/releases.ts
+++ b/frontend/src/API/releases.ts
@@ -65,15 +65,14 @@ export function useGetReleaseManifest({
 }: {
   namespace: string;
   chartName: string;
-  options?: UseQueryOptions<ReleaseManifest[]>;
+  options?: UseQueryOptions<string>;
 }) {
-  return useQuery<ReleaseManifest[]>({
+  return useQuery<string>({
     queryKey: ["manifest", namespace, chartName],
     queryFn: () =>
-      apiService.fetchWithSafeDefaults<ReleaseManifest[]>({
-        url: `/api/helm/releases/${namespace}/${chartName}/manifests`,
-        fallback: [],
-      }),
+      apiService.fetchWithDefaults<string>(
+        `/api/helm/releases/${namespace}/${chartName}/manifests`
+      ),
     ...(options ?? {}),
   });
 }
diff --git a/frontend/src/components/modal/InstallChartModal/InstallReleaseChartModal.tsx b/frontend/src/components/modal/InstallChartModal/InstallReleaseChartModal.tsx
index 213592a..8c420c0 100644
--- a/frontend/src/components/modal/InstallChartModal/InstallReleaseChartModal.tsx
+++ b/frontend/src/components/modal/InstallChartModal/InstallReleaseChartModal.tsx
@@ -143,7 +143,7 @@ export const InstallReleaseChartModal = ({
   } = useDiffData({
     selectedRepo,
     versionsError: versionsError as unknown as string, // TODO fix it
-    currentVerManifest: currentVerManifest as unknown as string, // TODO fix it
+    currentVerManifest: currentVerManifest ?? "",
     selectedVerData,
     chart: chartAddress,
   });