From 7e32008bfe2f731fe6edb39a02c88bd726cb45fb Mon Sep 17 00:00:00 2001 From: Todd Turner Date: Fri, 27 Jan 2023 00:12:16 +1000 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20Allow=20binary=20arguments=20via?= =?UTF-8?q?=20helm=20chart=20(#201)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit allows to pass arguments to the helm chart. This is useful if you want to specify arguments for the helm-dashboard binary whilst deploying via helm. --- charts/helm-dashboard/README.md | 1 + charts/helm-dashboard/templates/deployment.yaml | 6 ++++++ charts/helm-dashboard/values.yaml | 4 ++++ 3 files changed, 11 insertions(+) diff --git a/charts/helm-dashboard/README.md b/charts/helm-dashboard/README.md index e45b4be..363d106 100644 --- a/charts/helm-dashboard/README.md +++ b/charts/helm-dashboard/README.md @@ -73,6 +73,7 @@ The following table lists the configurable parameters of the chart and their def | `dashboard.persistence.size` | Persistent Volume size | `100M` | | `dashboard.persistence.hostPath` | Set path in case you want to use local host path volumes (not recommended in production) | `""` | `updateStrategy.type` | Set up update strategy for helm-dashboard installation. | `RollingUpdate` | +| `extraArgs` | Set the arguments to be supplied to the helm-dashboard binary | `[--no-browser, --bind=0.0.0.0]` Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. diff --git a/charts/helm-dashboard/templates/deployment.yaml b/charts/helm-dashboard/templates/deployment.yaml index c38beda..84ac661 100644 --- a/charts/helm-dashboard/templates/deployment.yaml +++ b/charts/helm-dashboard/templates/deployment.yaml @@ -30,6 +30,12 @@ spec: {{- toYaml .Values.podSecurityContext | nindent 8 }} containers: - name: {{ .Chart.Name }} + command: + - /bin/helm-dashboard + args: + {{- with .Values.extraArgs }} + {{- toYaml . | nindent 12 }} + {{- end }} securityContext: {{- toYaml .Values.securityContext | nindent 12 }} image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" diff --git a/charts/helm-dashboard/values.yaml b/charts/helm-dashboard/values.yaml index 1ba978d..aa795db 100644 --- a/charts/helm-dashboard/values.yaml +++ b/charts/helm-dashboard/values.yaml @@ -111,6 +111,10 @@ autoscaling: nodeSelector: {} +extraArgs: + - --no-browser + - --bind=0.0.0.0 + tolerations: [] affinity: {}