From 7ab0f332010050abf9a69542258627966022c835 Mon Sep 17 00:00:00 2001 From: Andrei Pohilko Date: Fri, 28 Oct 2022 19:10:53 +0100 Subject: [PATCH] Transfer TODOs into GH issues --- pkg/dashboard/handlers/helmHandlers.go | 2 -- pkg/dashboard/static/index.html | 4 +++- pkg/dashboard/subproc/data.go | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/dashboard/handlers/helmHandlers.go b/pkg/dashboard/handlers/helmHandlers.go index 617e136..44787dd 100644 --- a/pkg/dashboard/handlers/helmHandlers.go +++ b/pkg/dashboard/handlers/helmHandlers.go @@ -23,8 +23,6 @@ func (h *HelmHandler) GetCharts(c *gin.Context) { c.IndentedJSON(http.StatusOK, res) } -// TODO: helm show chart komodorio/k8s-watcher to get the icon URL - func (h *HelmHandler) Uninstall(c *gin.Context) { qp, err := utils.GetQueryProps(c, false) if err != nil { diff --git a/pkg/dashboard/static/index.html b/pkg/dashboard/static/index.html index 655fb93..cb1cc57 100644 --- a/pkg/dashboard/static/index.html +++ b/pkg/dashboard/static/index.html @@ -111,9 +111,11 @@ URL: http://somerepo/somepath + + + -->
Chart Name
diff --git a/pkg/dashboard/subproc/data.go b/pkg/dashboard/subproc/data.go index 17bb12d..248a874 100644 --- a/pkg/dashboard/subproc/data.go +++ b/pkg/dashboard/subproc/data.go @@ -58,7 +58,6 @@ func (d *DataLayer) runCommandHelm(cmd ...string) (string, error) { } func (d *DataLayer) runCommandKubectl(cmd ...string) (string, error) { - // TODO: migrate into using kubectl "k8s.io/kubectl/pkg/cmd" and kube API if d.Kubectl == "" { d.Kubectl = "kubectl" }