From 87ee388bfb5258c33dd479ee8a05145c86dd9761 Mon Sep 17 00:00:00 2001 From: ronahk Date: Sun, 15 Jan 2023 12:18:40 +0200 Subject: [PATCH 1/4] Handle errors in regex match --- pkg/dashboard/static/list-view.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/dashboard/static/list-view.js b/pkg/dashboard/static/list-view.js index ca2ee23..b8530a2 100644 --- a/pkg/dashboard/static/list-view.js +++ b/pkg/dashboard/static/list-view.js @@ -45,9 +45,15 @@ function buildChartCard(elm) { `) let chartName = elm.chart + let match = null // semver2 regex , add optional v prefix const chartNameRegex = 'v?(0|[1-9]\\d*)\\.(0|[1-9]\\d*)\\.(0|[1-9]\\d*)(?:-((?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\\.(?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\\+([0-9a-zA-Z-]+(?:\\.[0-9a-zA-Z-]+)*))?' - const match = elm.chart.match(chartNameRegex); + if (!new RegExp(chartNameRegex).test(chartName)) { + alert('Chart name does not match chart name regex.') + } else { + match = chartName.match(chartNameRegex); + } + if (match) { chartName = elm.chart.substring(0, match.index - 1) } else { From 40ae82918693710c3d487f732df22dafcd105518 Mon Sep 17 00:00:00 2001 From: ronahk Date: Sun, 15 Jan 2023 12:46:21 +0200 Subject: [PATCH 2/4] Use v3 checkout action in all places --- .github/workflows/publish-chart.yaml | 2 +- .github/workflows/release.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish-chart.yaml b/.github/workflows/publish-chart.yaml index abbd349..cefa903 100644 --- a/.github/workflows/publish-chart.yaml +++ b/.github/workflows/publish-chart.yaml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 - name: Bump versions diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 811e6c5..df83219 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -64,7 +64,7 @@ jobs: timeout-minutes: 60 steps: - name: Check out the repo - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Docker meta uses: docker/metadata-action@v3 @@ -95,7 +95,7 @@ jobs: if: github.event_name == 'push' || github.event_name == 'workflow_dispatch' steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 0 - name: Bump versions From 50947e585d6e14a409e8e03dc2ac75c7e06e4f6f Mon Sep 17 00:00:00 2001 From: ronahk <74967920+ronahk@users.noreply.github.com> Date: Sun, 15 Jan 2023 13:25:41 +0200 Subject: [PATCH 3/4] Break filters text when resizing window (#190) --- pkg/dashboard/static/styles.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/dashboard/static/styles.css b/pkg/dashboard/static/styles.css index 3d28599..58d9eb9 100644 --- a/pkg/dashboard/static/styles.css +++ b/pkg/dashboard/static/styles.css @@ -89,10 +89,11 @@ body > .container-fluid { #filters { overflow: hidden; - white-space: nowrap; text-overflow: ellipsis; font-size: 0.8rem; line-height: 175%; + inline-size: auto; + overflow-wrap: break-word; } #cluster input, #cluster span { From 26e0b1db32874bc4e4eda105c72ecb39f6c7ca88 Mon Sep 17 00:00:00 2001 From: ronahk Date: Sun, 15 Jan 2023 13:40:06 +0200 Subject: [PATCH 4/4] Fix typo in readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index cebbd2b..af747d2 100644 --- a/README.md +++ b/README.md @@ -90,7 +90,7 @@ Download the appropriate [release package](https://github.com/komodorio/helm-das ## Execute Helm tests -For all the release(s) (istalled helm charts), you can execute helm tests for that release. For the tests to execute successfully, you need to have existing tests for that helm chart +For all the release(s) (installed helm charts), you can execute helm tests for that release. For the tests to execute successfully, you need to have existing tests for that helm chart. You can execute `helm test` for the specific release as below: ![](screenshot_run_test.png)